Release 5.0.6

classic Classic list List threaded Threaded
16 messages Options
Reply | Threaded
Open this post in threaded view
|

Release 5.0.6

sfeam
The source tarball for gnuplot release 5.0.6 is now available on SourceForge.

Changes in 5.0.6
================
* NEW command 'set micro' enables encoding-specific char for gprintf %c format
* NEW command 'set datafile missing NaN' treats invalid data as if it were missing
* NEW backport updated svg/domterm terminal from development version
* CHANGE - start/end limits in nested iterations are reevaluated dynamically
* CHANGE - revised adjustment of x2label and plot title when x2tics are present
* CHANGE - mark non-free pdf terminal DEPRECATED (to be removed in release 5.2)
* CHANGE - allow fractional font sizes for gdlib terminals
* CHANGE - do not allow inverted R axis (requires support not backported from 5.1)
* CHANGE - allow pointinterval property in 'with lp' for splot as well as for plot
* CHANGE - "linewidth <lw>" is accepted as a terminal option for aquaterm, qt, wxt
* CHANGE - spline segments outside xrange are ignored rather than treated as errors
* FIX assignment of x/y dimensions in "binary record=(a,b) ... with image"
* FIX wxt - multithreaded wxt was faulting during resize (mutex lock failure)
* FIX windows - timed pause only worked for intervals < 1 second
* FIX Front/back layering of border+grid lines was not always correct in hidden3d
* FIX "set pm3d depthorder interpolate N,M" memory allocation failure
* FIX aquaterm failed to honor request to disable enhanced text markup
* FIX save and show commands failed to list linecolor for lines with "lt -1"
* FIX the "missing" data flag is honored by "using ($n)" as it is for "using n"
* FIX error reporting of line number inside a bracketed clause
* FIX gnuplot_x11: possible fix for sporadic use-after-free error
* FIX initialization of hidden3d structures for splot with dots
* FIX track arrowhead properties in hidden3d mode
* FIX tracking of NaN values from function evaluated during binary data input
* FIX 3D rotation does not clobber hidden/visible status of plots


        happy gnuplotting

                Ethan

   



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
gnuplot-beta mailing list
[hidden email]
Membership management via: https://lists.sourceforge.net/lists/listinfo/gnuplot-beta
Reply | Threaded
Open this post in threaded view
|

Re: Release 5.0.6

tmacchant
----- Original Message -----

> From: sfeam
> To: gnuplot-beta
> Cc:
> Date: 2017/3/18, Sat 13:08
> Subject: Release 5.0.6
>
>T he source tarball for gnuplot release 5.0.6 is now available on SourceForge.
>
> Changes in 5.0.6
> ================
> * NEW command 'set micro' enables encoding-specific char for gprintf %c
> format
> * NEW command 'set datafile missing NaN' treats invalid data as if it
> were missing
> * NEW backport updated svg/domterm terminal from development version
> * CHANGE - start/end limits in nested iterations are reevaluated dynamically
> * CHANGE - revised adjustment of x2label and plot title when x2tics are present
> * CHANGE - mark non-free pdf terminal DEPRECATED (to be removed in release 5.2)
> * CHANGE - allow fractional font sizes for gdlib terminals
> * CHANGE - do not allow inverted R axis (requires support not backported from
> 5.1)
> * CHANGE - allow pointinterval property in 'with lp' for splot as well
> as for plot
> * CHANGE - "linewidth <lw>" is accepted as a terminal option for
> aquaterm, qt, wxt
> * CHANGE - spline segments outside xrange are ignored rather than treated as
> errors
> * FIX assignment of x/y dimensions in "binary record=(a,b) ... with
> image"
> * FIX wxt - multithreaded wxt was faulting during resize (mutex lock failure)
> * FIX windows - timed pause only worked for intervals < 1 second
> * FIX Front/back layering of border+grid lines was not always correct in
> hidden3d
> * FIX "set pm3d depthorder interpolate N,M" memory allocation failure
> * FIX aquaterm failed to honor request to disable enhanced text markup
> * FIX save and show commands failed to list linecolor for lines with "lt
> -1"
> * FIX the "missing" data flag is honored by "using ($n)" as
> it is for "using n"
> * FIX error reporting of line number inside a bracketed clause
> * FIX gnuplot_x11: possible fix for sporadic use-after-free error
> * FIX initialization of hidden3d structures for splot with dots
> * FIX track arrowhead properties in hidden3d mode
> * FIX tracking of NaN values from function evaluated during binary data input
> * FIX 3D rotation does not clobber hidden/visible status of plots
>
>
>     happy gnuplotting
>
>         Ethan
>

I have tried to build gnuplot 5.0.6 on windows.
However, gnuplot_qt process fails to start

For starting qt terminal

gnuplot> set term qt
gnuplot> plot x

Warning: slow font initializationgnuplot>

Seeing task (process) manager on windows 10, I cannot see gnuplot_qt.exe.
This does not happens on gnuplot-5.0.6pre and 5.1 (2017-03-19).

I have tried both my original build dependency and msys2 dependency.
But results are the same

@Bastian

Did you see the similar phenomenon?

Tatsuro


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
gnuplot-beta mailing list
[hidden email]
Membership management via: https://lists.sourceforge.net/lists/listinfo/gnuplot-beta
Reply | Threaded
Open this post in threaded view
|

qt terminal trouble 5.0.6 source on windows build (was Re: Release 5.0.6)

tmacchant


----- Original Message -----

> From: Tatsuro MATSUOKA
> To: Merritt Ethan  gnuplot-beta bmaerkisch tmacchant3
> Cc:
> Date: 2017/3/21, Tue 11:16
> Subject: Re: Release 5.0.6
>
> ----- Original Message -----
>
>>  From: sfeam
>>  To: gnuplot-beta
>>  Cc:
>>  Date: 2017/3/18, Sat 13:08
>>  Subject: Release 5.0.6
>>
>> T he source tarball for gnuplot release 5.0.6 is now available on
> SourceForge.
>>
>>  Changes in 5.0.6
>>  ================
>>  * NEW command 'set micro' enables encoding-specific char for
> gprintf %c
>>  format
>>  * NEW command 'set datafile missing NaN' treats invalid data as if
> it
>>  were missing
>>  * NEW backport updated svg/domterm terminal from development version
>>  * CHANGE - start/end limits in nested iterations are reevaluated
> dynamically
>>  * CHANGE - revised adjustment of x2label and plot title when x2tics are
> present
>>  * CHANGE - mark non-free pdf terminal DEPRECATED (to be removed in release
> 5.2)
>>  * CHANGE - allow fractional font sizes for gdlib terminals
>>  * CHANGE - do not allow inverted R axis (requires support not backported
> from
>>  5.1)
>>  * CHANGE - allow pointinterval property in 'with lp' for splot as
> well
>>  as for plot
>>  * CHANGE - "linewidth <lw>" is accepted as a terminal
> option for
>>  aquaterm, qt, wxt
>>  * CHANGE - spline segments outside xrange are ignored rather than treated
> as
>>  errors
>>  * FIX assignment of x/y dimensions in "binary record=(a,b) ... with
>>  image"
>>  * FIX wxt - multithreaded wxt was faulting during resize (mutex lock
> failure)
>>  * FIX windows - timed pause only worked for intervals < 1 second
>>  * FIX Front/back layering of border+grid lines was not always correct in
>>  hidden3d
>>  * FIX "set pm3d depthorder interpolate N,M" memory allocation
> failure
>>  * FIX aquaterm failed to honor request to disable enhanced text markup
>>  * FIX save and show commands failed to list linecolor for lines with
> "lt
>>  -1"
>>  * FIX the "missing" data flag is honored by "using
> ($n)" as
>>  it is for "using n"
>>  * FIX error reporting of line number inside a bracketed clause
>>  * FIX gnuplot_x11: possible fix for sporadic use-after-free error
>>  * FIX initialization of hidden3d structures for splot with dots
>>  * FIX track arrowhead properties in hidden3d mode
>>  * FIX tracking of NaN values from function evaluated during binary data
> input
>>  * FIX 3D rotation does not clobber hidden/visible status of plots
>>
>>
>>      happy gnuplotting
>>
>>          Ethan
>>
>
> I have tried to build gnuplot 5.0.6 on windows.
> However, gnuplot_qt process fails to start
>
> For starting qt terminal
>
> gnuplot> set term qt
> gnuplot> plot x
>
> Warning: slow font initializationgnuplot>
>
> Seeing task (process) manager on windows 10, I cannot see gnuplot_qt.exe.
> This does not happens on gnuplot-5.0.6pre and 5.1 (2017-03-19).
>
> I have tried both my original build dependency and msys2 dependency.
> But results are the same
>
> @Bastian
>
> Did you see the similar phenomenon?
>
> Tatsuro

I checked changes after pre-release of 5.0.6 and found that
the change


2017-03-08  Ethan A Merritt  <[hidden email]>

    * src/qtterminal/QtGnuplotEvent.h: Move new enum GEPID (2017-02-25) to
    end of enum list rather than in the middle.  Otherwise the gnuplot_qt
    built for 5.0.6 is incompatible with gnuplot executables 5.0.0-5, which
    makes comparison of multiple versions to debug things harder than it
    needs to be.  If the new event is at the end, all earlier gnuplot 5.0.x
    versions can share gnuplot_qt 5.0.6.

prevents gnuplot_qt.exe to start on windows.

I do not have enough knowledge so that I do not know why this change causes
trouble on qt terminal for windows.

Tatsuro

 


Tatsuro


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
gnuplot-beta mailing list
[hidden email]
Membership management via: https://lists.sourceforge.net/lists/listinfo/gnuplot-beta
Reply | Threaded
Open this post in threaded view
|

Re: qt terminal trouble 5.0.6 source on windows build (was Re: Release 5.0.6)

tmacchant
----- Original Message -----

> From: Tatsuro MATSUOKA >
To: tmacchant3 Merritt Ethan ; gnuplot-beta bmaerkisch
> Cc:
> Date: 2017/3/21, Tue 13:08
> Subject: qt terminal trouble 5.0.6 source on windows build (was Re: Release 5.0.6)
>
>
>
[snip]

>>  I have tried to build gnuplot 5.0.6 on windows.
>>  However, gnuplot_qt process fails to start
>>
>>  For starting qt terminal
>>
>>  gnuplot> set term qt
>>  gnuplot> plot x
>>
>>  Warning: slow font initializationgnuplot>
>>
>>  Seeing task (process) manager on windows 10, I cannot see gnuplot_qt.exe.
>>  This does not happens on gnuplot-5.0.6pre and 5.1 (2017-03-19).
>>
>>  I have tried both my original build dependency and msys2 dependency.
>>  But results are the same
>>
>>  @Bastian
>>
>>  Did you see the similar phenomenon?
>>
>>  Tatsuro
>
> I checked changes after pre-release of 5.0.6 and found that
> the change
>
>
> 2017-03-08  Ethan A Merritt  <[hidden email]>
>
>     * src/qtterminal/QtGnuplotEvent.h: Move new enum GEPID (2017-02-25) to
>     end of enum list rather than in the middle.  Otherwise the gnuplot_qt
>     built for 5.0.6 is incompatible with gnuplot executables 5.0.0-5, which
>     makes comparison of multiple versions to debug things harder than it
>     needs to be.  If the new event is at the end, all earlier gnuplot 5.0.x
>     versions can share gnuplot_qt 5.0.6.
>
> prevents gnuplot_qt.exe to start on windows.
>
> I do not have enough knowledge so that I do not know why this change causes
> trouble on qt terminal for windows.
>
> Tatsuro

I have executed gdb trace.

gnuplot_qt starts but terminates at start_plot



Thread 1 hit Breakpoint 1, execGnuplotQt ()
    at ../../src/qtterminal/qt_term.cpp:229
229             QString filename;
(gdb) n
230             char* path = getenv("GNUPLOT_DRIVER_DIR");
(gdb) n
231             if (path)
(gdb) n
233             if (filename.isEmpty()) {
(gdb) n
235                     filename = QCoreApplication::applicationDirPath();
(gdb) n
241             filename += "/";
(gdb) n
242             filename += GNUPLOT_QT;
(gdb) n
245             qt->gnuplot_qtStarted = QProcess::startDetached(filename, QStringList(), QString(), &pid);
(gdb) n
246             if (qt->gnuplot_qtStarted) { 
Here gnuplot_qt started

(gdb) n
247                     qt->localServerName = "qtgnuplot" + QString::number(pid);
(gdb) n
250                     qt->pid = pid;
(gdb) n
229             QString filename;
(gdb) n
255     }
(gdb) n
qt_init () at ../../src/qtterminal/qt_term.cpp:440
440             setlocale(LC_NUMERIC, "C");
(gdb) n
441             setlocale(LC_TIME, current_locale);
(gdb) n
444             qt->out.setVersion(QDataStream::Qt_4_4);
(gdb) n
445             term_interlock = (void *)qt_init;
(gdb) n
446             gp_atexit(qt_atexit);
(gdb) n
447     }
(gdb) n
term_initialise () at ../../src/term.c:502
502             term_initialised = TRUE;
(gdb) n
504     }
(gdb) n
[New Thread 8800.0x10f4]
do_plot (plots=0x4ca54b0, pcount=1) at ../../src/graphics.c:523
523         term_start_plot();
(gdb) n
Here gnuplot_qt terminates.

I dig into term_start_plot(); by step command.

523         term_start_plot();
(gdb) s
term_start_plot () at ../../src/term.c:512
512         if (!term_initialised)
(gdb) s
515         if (!term_graphics) {
(gdb) s
517             (*term->graphics) ();
(gdb) s
qt_graphics () at ../../src/qtterminal/qt_term.cpp:514
514             ensureOptionsCreated();
(gdb) n
515             qt->out << GEDesactivate;
(gdb) n
516             qt_flushOutBuffer();
(gdb) n
517             qt_connectToServer();
(gdb) n
520             if (!(qt->codec = qt_encodingToCodec(encoding)))
(gdb) n
524             qt->currentFontSize = qt_optionFontSize;
(gdb) n
525             qt->currentFontName = qt_option->FontName;
(gdb) n
528             if (qt_setSize)
(gdb) n
530                     term->xmax = qt_oversampling*qt_setWidth;
(gdb) n
531                     term->ymax = qt_oversampling*qt_setHeight;
(gdb) n
532                     qt_setSize = false;
(gdb) n
536             qt->out << GESetCurrentWindow << qt_optionWindowId;
(gdb) n
537             qt->out << GEInitWindow;
(gdb) n
540             qt->out << GEPID << quint32(GetCurrentProcessId());
(gdb) n
542             qt->out << GEActivate;
(gdb) n
543             qt->out << GETitle << qt_option->Title;
(gdb) n
544             qt->out << GESetCtrl << qt_optionCtrl;
(gdb) n
545             qt->out << GESetWidgetSize << QSize(term->xmax, term->ymax)/qt_oversampling;
(gdb) n
547             qt->out << GESetSceneSize << QSize(term->xmax, term->ymax)/qt_oversampling;
(gdb) n
548             qt->out << GEClear;
(gdb) n
550             qt_sendFont();
(gdb) n

Here gnuplot_qt terminates.

Perhaps
"Move new enum GEPID (2017-02-25) to end of enum list rather than in the middle"
affects the gnuplot_qt execution on windows but I cannot give fix for this issue.

But this is a serious bug of gnuplot for windows and should be corrected.

Tatsuro

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
gnuplot-beta mailing list
[hidden email]
Membership management via: https://lists.sourceforge.net/lists/listinfo/gnuplot-beta
Reply | Threaded
Open this post in threaded view
|

Aw: Re: Release 5.0.6

Bastian Märkisch
In reply to this post by tmacchant
Dear Tatsuro,

Indeed I experienced the same problem on my system. At least at first. I am now unable to reproduce the problem with an unmodified 5.0.6 source tree (except for the Makefile options). After many test builds, it seems that the only source of for that error left that I could think is a race condition during build. In particular changing the definitions of QEPID does not make a difference. So I suggest you do a "make veryclean && make windows" and try again.

  Bastian

> Gesendet: Dienstag, 21. März 2017 um 03:16 Uhr
> Von: "Tatsuro MATSUOKA" <[hidden email]>
> An: "Merritt Ethan" <[hidden email]>, [hidden email], [hidden email], [hidden email]
> Betreff: Re: Release 5.0.6
>
> ----- Original Message -----
>
> > From: sfeam
> > To: gnuplot-beta
> > Cc:
> > Date: 2017/3/18, Sat 13:08
> > Subject: Release 5.0.6
> >
> >T he source tarball for gnuplot release 5.0.6 is now available on SourceForge.
> >
> > Changes in 5.0.6
> > ================
> > * NEW command 'set micro' enables encoding-specific char for gprintf %c
> > format
> > * NEW command 'set datafile missing NaN' treats invalid data as if it
> > were missing
> > * NEW backport updated svg/domterm terminal from development version
> > * CHANGE - start/end limits in nested iterations are reevaluated dynamically
> > * CHANGE - revised adjustment of x2label and plot title when x2tics are present
> > * CHANGE - mark non-free pdf terminal DEPRECATED (to be removed in release 5.2)
> > * CHANGE - allow fractional font sizes for gdlib terminals
> > * CHANGE - do not allow inverted R axis (requires support not backported from
> > 5.1)
> > * CHANGE - allow pointinterval property in 'with lp' for splot as well
> > as for plot
> > * CHANGE - "linewidth <lw>" is accepted as a terminal option for
> > aquaterm, qt, wxt
> > * CHANGE - spline segments outside xrange are ignored rather than treated as
> > errors
> > * FIX assignment of x/y dimensions in "binary record=(a,b) ... with
> > image"
> > * FIX wxt - multithreaded wxt was faulting during resize (mutex lock failure)
> > * FIX windows - timed pause only worked for intervals < 1 second
> > * FIX Front/back layering of border+grid lines was not always correct in
> > hidden3d
> > * FIX "set pm3d depthorder interpolate N,M" memory allocation failure
> > * FIX aquaterm failed to honor request to disable enhanced text markup
> > * FIX save and show commands failed to list linecolor for lines with "lt
> > -1"
> > * FIX the "missing" data flag is honored by "using ($n)" as
> > it is for "using n"
> > * FIX error reporting of line number inside a bracketed clause
> > * FIX gnuplot_x11: possible fix for sporadic use-after-free error
> > * FIX initialization of hidden3d structures for splot with dots
> > * FIX track arrowhead properties in hidden3d mode
> > * FIX tracking of NaN values from function evaluated during binary data input
> > * FIX 3D rotation does not clobber hidden/visible status of plots
> >
> >
> >     happy gnuplotting
> >
> >         Ethan
> >
>
> I have tried to build gnuplot 5.0.6 on windows.
> However, gnuplot_qt process fails to start
>
> For starting qt terminal
>
> gnuplot> set term qt
> gnuplot> plot x
>
> Warning: slow font initializationgnuplot>
>
> Seeing task (process) manager on windows 10, I cannot see gnuplot_qt.exe.
> This does not happens on gnuplot-5.0.6pre and 5.1 (2017-03-19).
>
> I have tried both my original build dependency and msys2 dependency.
> But results are the same
>
> @Bastian
>
> Did you see the similar phenomenon?
>
> Tatsuro
>
>

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
gnuplot-beta mailing list
[hidden email]
Membership management via: https://lists.sourceforge.net/lists/listinfo/gnuplot-beta
Reply | Threaded
Open this post in threaded view
|

Re: Aw: Re: Release 5.0.6

sfeam
On Tuesday, 21 March 2017 10:19:59 AM Bastian Märkisch wrote:
> Dear Tatsuro,
>
> Indeed I experienced the same problem on my system. At least at first. I am now unable to reproduce the problem with an unmodified 5.0.6 source tree (except for the Makefile options). After many test builds, it seems that the only source of for that error left that I could think is a race condition during build. In particular changing the definitions of QEPID does not make a difference. So I suggest you do a "make veryclean && make windows" and try again.

Could it be that the OS caches a previously-used copy of gnuplot_qt, so that even when
you build a new one in practice it uses the old one?  That would explain everything.

The problem you are now seeing sounds exactly like the problem I saw when the
new QEPID was originally added in the middle of the definition list.  It made the new
gnuplot executable incompatible with my old gnuplot_qt, and vice versa it made the
new gnuplot_qt incompatible with the gnuplot executables previously built for
5.0.0 5.0.1 5.0.2 etc.  

        Ethan


>
>   Bastian
>
> > Gesendet: Dienstag, 21. März 2017 um 03:16 Uhr
> > Von: "Tatsuro MATSUOKA" <[hidden email]>
> > An: "Merritt Ethan" <[hidden email]>, [hidden email], [hidden email], [hidden email]
> > Betreff: Re: Release 5.0.6
> >
> > ----- Original Message -----
> >
> > > From: sfeam
> > > To: gnuplot-beta
> > > Cc:
> > > Date: 2017/3/18, Sat 13:08
> > > Subject: Release 5.0.6
> > >
> > >T he source tarball for gnuplot release 5.0.6 is now available on SourceForge.
> > >
> > > Changes in 5.0.6
> > > ================
> > > * NEW command 'set micro' enables encoding-specific char for gprintf %c
> > > format
> > > * NEW command 'set datafile missing NaN' treats invalid data as if it
> > > were missing
> > > * NEW backport updated svg/domterm terminal from development version
> > > * CHANGE - start/end limits in nested iterations are reevaluated dynamically
> > > * CHANGE - revised adjustment of x2label and plot title when x2tics are present
> > > * CHANGE - mark non-free pdf terminal DEPRECATED (to be removed in release 5.2)
> > > * CHANGE - allow fractional font sizes for gdlib terminals
> > > * CHANGE - do not allow inverted R axis (requires support not backported from
> > > 5.1)
> > > * CHANGE - allow pointinterval property in 'with lp' for splot as well
> > > as for plot
> > > * CHANGE - "linewidth <lw>" is accepted as a terminal option for
> > > aquaterm, qt, wxt
> > > * CHANGE - spline segments outside xrange are ignored rather than treated as
> > > errors
> > > * FIX assignment of x/y dimensions in "binary record=(a,b) ... with
> > > image"
> > > * FIX wxt - multithreaded wxt was faulting during resize (mutex lock failure)
> > > * FIX windows - timed pause only worked for intervals < 1 second
> > > * FIX Front/back layering of border+grid lines was not always correct in
> > > hidden3d
> > > * FIX "set pm3d depthorder interpolate N,M" memory allocation failure
> > > * FIX aquaterm failed to honor request to disable enhanced text markup
> > > * FIX save and show commands failed to list linecolor for lines with "lt
> > > -1"
> > > * FIX the "missing" data flag is honored by "using ($n)" as
> > > it is for "using n"
> > > * FIX error reporting of line number inside a bracketed clause
> > > * FIX gnuplot_x11: possible fix for sporadic use-after-free error
> > > * FIX initialization of hidden3d structures for splot with dots
> > > * FIX track arrowhead properties in hidden3d mode
> > > * FIX tracking of NaN values from function evaluated during binary data input
> > > * FIX 3D rotation does not clobber hidden/visible status of plots
> > >
> > >
> > >     happy gnuplotting
> > >
> > >         Ethan
> > >
> >
> > I have tried to build gnuplot 5.0.6 on windows.
> > However, gnuplot_qt process fails to start
> >
> > For starting qt terminal
> >
> > gnuplot> set term qt
> > gnuplot> plot x
> >
> > Warning: slow font initializationgnuplot>
> >
> > Seeing task (process) manager on windows 10, I cannot see gnuplot_qt.exe.
> > This does not happens on gnuplot-5.0.6pre and 5.1 (2017-03-19).
> >
> > I have tried both my original build dependency and msys2 dependency.
> > But results are the same
> >
> > @Bastian
> >
> > Did you see the similar phenomenon?
> >
> > Tatsuro
> >
> >
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> gnuplot-beta mailing list
> [hidden email]
> Membership management via: https://lists.sourceforge.net/lists/listinfo/gnuplot-beta
>


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
gnuplot-beta mailing list
[hidden email]
Membership management via: https://lists.sourceforge.net/lists/listinfo/gnuplot-beta
Reply | Threaded
Open this post in threaded view
|

Re: Aw: Re: Release 5.0.6

tmacchant
----- Original Message -----

> From: sfeam
> To: gnuplot-beta
> Cc: Bastian Märkisch ; tmacchant3
> Date: 2017/3/22, Wed 00:37
> Subject: Re: Aw: Re: Release 5.0.6
>
> On Tuesday, 21 March 2017 10:19:59 AM Bastian Märkisch wrote:
>>  Dear Tatsuro,
>>
>>  Indeed I experienced the same problem on my system. At least at first. I am
> now unable to reproduce the problem with an unmodified 5.0.6 source tree (except
> for the Makefile options). After many test builds, it seems that the only source
> of for that error left that I could think is a race condition during build. In
> particular changing the definitions of QEPID does not make a difference. So I
> suggest you do a "make veryclean && make windows" and try
> again.
>
> Could it be that the OS caches a previously-used copy of gnuplot_qt, so that
> even when
> you build a new one in practice it uses the old one?  That would explain
> everything.
>
> The problem you are now seeing sounds exactly like the problem I saw when the
> new QEPID was originally added in the middle of the definition list.  It made
> the new
> gnuplot executable incompatible with my old gnuplot_qt, and vice versa it made
> the
> new gnuplot_qt incompatible with the gnuplot executables previously built for
> 5.0.0 5.0.1 5.0.2 etc. 
>
>     Ethan
>
>
>>
>>    Bastian

Dear Bastian and Ethan

Thanks for replies.

I rebooted PC and deleted the previous source tress and extract freshly.
And I tried to build again.

However, I cannot get successful results
I tried on both gcc-5.3.0 and gcc-6.3.0 on64 bits, gcc-5.3.0 on 32 bit.

It seems that the issue depends on my local environments and is is not a bug.
Anyway I cannot provide windows binaries for 5.0.6 at the moment.

Tatsuro

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
gnuplot-beta mailing list
[hidden email]
Membership management via: https://lists.sourceforge.net/lists/listinfo/gnuplot-beta
Reply | Threaded
Open this post in threaded view
|

Re: qt terminal trouble 5.0.6 source on windows build (was Re: Release 5.0.6)

sfeam
In reply to this post by tmacchant
On Tuesday, 21 March 2017 01:08:48 PM Tatsuro MATSUOKA wrote:

> I checked changes after pre-release of 5.0.6 and found that
> the change
>
>
> 2017-03-08  Ethan A Merritt  <[hidden email]>
>
>     * src/qtterminal/QtGnuplotEvent.h: Move new enum GEPID (2017-02-25) to
>     end of enum list rather than in the middle.  Otherwise the gnuplot_qt
>     built for 5.0.6 is incompatible with gnuplot executables 5.0.0-5, which
>     makes comparison of multiple versions to debug things harder than it
>     needs to be.  If the new event is at the end, all earlier gnuplot 5.0.x
>     versions can share gnuplot_qt 5.0.6.
>
> prevents gnuplot_qt.exe to start on windows.
>
> I do not have enough knowledge so that I do not know why this change causes
> trouble on qt terminal for windows.

Have you confirmed that it really is that one change?
Does commenting out this one line in qt_term.cpp make it work again?

diff -urp gnuplot-5.0.6pre/src/qtterminal/qt_term.cpp gnuplot-5.0.6/src/qtterminal/qt_term.cpp
--- gnuplot-5.0.6pre/src/qtterminal/qt_term.cpp 2017-02-25 14:18:30.000000000 -0800
+++ gnuplot-5.0.6/src/qtterminal/qt_term.cpp    2017-03-21 19:49:24.159719912 -0700
@@ -537,7 +537,7 @@ void qt_graphics()
        qt->out << GEInitWindow;
 #ifdef _WIN32
        // Let the terminal window know our PID
-       qt->out << GEPID << quint32(GetCurrentProcessId());
+       // qt->out << GEPID << quint32(GetCurrentProcessId());
 #endif
        qt->out << GEActivate;
        qt->out << GETitle << qt_option->Title;


> Tatsuro
>


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
gnuplot-beta mailing list
[hidden email]
Membership management via: https://lists.sourceforge.net/lists/listinfo/gnuplot-beta
Reply | Threaded
Open this post in threaded view
|

Re: qt terminal trouble 5.0.6 source on windows build (was Re: Release 5.0.6)

tmacchant
----- Original Message -----

> From: sfeam
> To: Tatsuro MATSUOKA
> Cc: gnuplot-beta bmaerkisch
> Date: 2017/3/22, Wed 11:54
> Subject: Re: qt terminal trouble 5.0.6 source on windows build (was Re: Release 5.0.6)
>
> On Tuesday, 21 March 2017 01:08:48 PM Tatsuro MATSUOKA wrote:
>>  I checked changes after pre-release of 5.0.6 and found that
>>  the change
>>
>>
>>  2017-03-08  Ethan A Merritt  <[hidden email]>
>>
>>      * src/qtterminal/QtGnuplotEvent.h: Move new enum GEPID (2017-02-25) to
>>      end of enum list rather than in the middle.  Otherwise the gnuplot_qt
>>      built for 5.0.6 is incompatible with gnuplot executables 5.0.0-5, which
>>      makes comparison of multiple versions to debug things harder than it
>>      needs to be.  If the new event is at the end, all earlier gnuplot 5.0.x
>>      versions can share gnuplot_qt 5.0.6.
>>
>>  prevents gnuplot_qt.exe to start on windows.
>>
>>  I do not have enough knowledge so that I do not know why this change causes
>
>>  trouble on qt terminal for windows.

>
> Have you confirmed that it really is that one change?

Yes.
I modified only  QtGnuplotEvent.h to before this change.
http://gnuplot.cvs.sourceforge.net/viewvc/gnuplot/gnuplot/src/qtterminal/QtGnuplotEvent.h?r1=1.13.2.1&r2=1.13.2.2
and gnuplot_qt works without problem


> Does commenting out this one line in qt_term.cpp make it work again?
>
> diff -urp gnuplot-5.0.6pre/src/qtterminal/qt_term.cpp
> gnuplot-5.0.6/src/qtterminal/qt_term.cpp
> --- gnuplot-5.0.6pre/src/qtterminal/qt_term.cpp 2017-02-25 14:18:30.000000000
> -0800
> +++ gnuplot-5.0.6/src/qtterminal/qt_term.cpp    2017-03-21 19:49:24.159719912
> -0700
> @@ -537,7 +537,7 @@ void qt_graphics()
>         qt->out << GEInitWindow;
> #ifdef _WIN32
>         // Let the terminal window know our PID
> -       qt->out << GEPID << quint32(GetCurrentProcessId());
> +       // qt->out << GEPID << quint32(GetCurrentProcessId());
> #endif
>         qt->out << GEActivate;
>         qt->out << GETitle << qt_option->Title;



Yes!

> +       // qt->out << GEPID << quint32(GetCurrentProcessId());

The comment out the above makes gnuplot_qt work.

Tatsuro


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
gnuplot-beta mailing list
[hidden email]
Membership management via: https://lists.sourceforge.net/lists/listinfo/gnuplot-beta
Reply | Threaded
Open this post in threaded view
|

Re: qt terminal trouble 5.0.6 source on windows build (was Re: Release 5.0.6)

sfeam
On Wednesday, 22 March, 2017 12:40:59 Tatsuro MATSUOKA wrote:

> ----- Original Message -----
>
> > From: sfeam
> > To: Tatsuro MATSUOKA
> > Cc: gnuplot-beta bmaerkisch
> > Date: 2017/3/22, Wed 11:54
> > Subject: Re: qt terminal trouble 5.0.6 source on windows build (was Re: Release 5.0.6)
> >
> > On Tuesday, 21 March 2017 01:08:48 PM Tatsuro MATSUOKA wrote:
> >>  I checked changes after pre-release of 5.0.6 and found that
> >>  the change
> >>
> >>
> >>  2017-03-08  Ethan A Merritt  <[hidden email]>
> >>
> >>      * src/qtterminal/QtGnuplotEvent.h: Move new enum GEPID (2017-02-25) to
> >>      end of enum list rather than in the middle.  Otherwise the gnuplot_qt
> >>      built for 5.0.6 is incompatible with gnuplot executables 5.0.0-5, which
> >>      makes comparison of multiple versions to debug things harder than it
> >>      needs to be.  If the new event is at the end, all earlier gnuplot 5.0.x
> >>      versions can share gnuplot_qt 5.0.6.
> >>
> >>  prevents gnuplot_qt.exe to start on windows.
> >>
> >>  I do not have enough knowledge so that I do not know why this change causes
> >
> >>  trouble on qt terminal for windows.
>
> >
> > Have you confirmed that it really is that one change?
>
> Yes.
> I modified only  QtGnuplotEvent.h to before this change.
> http://gnuplot.cvs.sourceforge.net/viewvc/gnuplot/gnuplot/src/qtterminal/QtGnuplotEvent.h?r1=1.13.2.1&r2=1.13.2.2
> and gnuplot_qt works without problem
>
>
> > Does commenting out this one line in qt_term.cpp make it work again?
> >
> > diff -urp gnuplot-5.0.6pre/src/qtterminal/qt_term.cpp
> > gnuplot-5.0.6/src/qtterminal/qt_term.cpp
> > --- gnuplot-5.0.6pre/src/qtterminal/qt_term.cpp 2017-02-25 14:18:30.000000000
> > -0800
> > +++ gnuplot-5.0.6/src/qtterminal/qt_term.cpp    2017-03-21 19:49:24.159719912
> > -0700
> > @@ -537,7 +537,7 @@ void qt_graphics()
> >         qt->out << GEInitWindow;
> > #ifdef _WIN32
> >         // Let the terminal window know our PID
> > -       qt->out << GEPID << quint32(GetCurrentProcessId());
> > +       // qt->out << GEPID << quint32(GetCurrentProcessId());
> > #endif
> >         qt->out << GEActivate;
> >         qt->out << GETitle << qt_option->Title;
>
>
>
> Yes!
>
> > +       // qt->out << GEPID << quint32(GetCurrentProcessId());
>
> The comment out the above makes gnuplot_qt work.
>
> Tatsuro

That demonstrates the problem is not due to changing the order of
symbols in enum QtGnuplotEventType.

There may be something wrong in the communication of pid information
between processes or possibly an error from the call to
AllowSetForegroundWindow(m_pid).  Maybe it needs error-checking?
Or sanity checking of the m_pid value?

Anyhow it seems from the symptoms you report that the error comes
from the code added to allow '--enable-raise-console'.  So I expect
that the cleanest option for building from unmodified source is to
configure with

   --disable-raise-console

or (same thing) add a line to config.h

    #define DISABLE_SPACE_RAISES_CONSOLE


                Ethan

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
gnuplot-beta mailing list
[hidden email]
Membership management via: https://lists.sourceforge.net/lists/listinfo/gnuplot-beta
Reply | Threaded
Open this post in threaded view
|

Re: qt terminal trouble 5.0.6 source on windows build (was Re: Release 5.0.6)

tmacchant
----- Original Message -----

> From: Ethan A Merritt <[hidden email]>
> To: [hidden email]; Tatsuro MATSUOKA <[hidden email]>
> Cc: [hidden email]
> Date: 2017/3/23, Thu 04:00
> Subject: Re: qt terminal trouble 5.0.6 source on windows build (was Re: Release 5.0.6)
>
> On Wednesday, 22 March, 2017 12:40:59 Tatsuro MATSUOKA wrote:
>>  ----- Original Message -----
>>
>>  > From: sfeam
>>  > To: Tatsuro MATSUOKA
>>  > Cc: gnuplot-beta bmaerkisch
>>  > Date: 2017/3/22, Wed 11:54
>>  > Subject: Re: qt terminal trouble 5.0.6 source on windows build (was
> Re: Release 5.0.6)
>>  >
>>  > On Tuesday, 21 March 2017 01:08:48 PM Tatsuro MATSUOKA wrote:
>>  >>  I checked changes after pre-release of 5.0.6 and found that
>>  >>  the change
>>  >>
>>  >>
>>  >>  2017-03-08  Ethan A Merritt  <[hidden email]>
>>  >>
>>  >>      * src/qtterminal/QtGnuplotEvent.h: Move new enum GEPID
> (2017-02-25) to
>>  >>      end of enum list rather than in the middle.  Otherwise the
> gnuplot_qt
>>  >>      built for 5.0.6 is incompatible with gnuplot executables
> 5.0.0-5, which
>>  >>      makes comparison of multiple versions to debug things harder
> than it
>>  >>      needs to be.  If the new event is at the end, all earlier
> gnuplot 5.0.x
>>  >>      versions can share gnuplot_qt 5.0.6.
>>  >>
>>  >>  prevents gnuplot_qt.exe to start on windows.
>>  >>
>>  >>  I do not have enough knowledge so that I do not know why this
> change causes
>>  >
>>  >>  trouble on qt terminal for windows.
>>
>>  >
>>  > Have you confirmed that it really is that one change?
>>
>>  Yes.
>>  I modified only  QtGnuplotEvent.h to before this change.
>>
> http://gnuplot.cvs.sourceforge.net/viewvc/gnuplot/gnuplot/src/qtterminal/QtGnuplotEvent.h?r1=1.13.2.1&r2=1.13.2.2
>>  and gnuplot_qt works without problem
>>
>>
>>  > Does commenting out this one line in qt_term.cpp make it work again?
>>  >
>>  > diff -urp gnuplot-5.0.6pre/src/qtterminal/qt_term.cpp
>>  > gnuplot-5.0.6/src/qtterminal/qt_term.cpp
>>  > --- gnuplot-5.0.6pre/src/qtterminal/qt_term.cpp 2017-02-25
> 14:18:30.000000000
>>  > -0800
>>  > +++ gnuplot-5.0.6/src/qtterminal/qt_term.cpp    2017-03-21
> 19:49:24.159719912
>>  > -0700
>>  > @@ -537,7 +537,7 @@ void qt_graphics()
>>  >         qt->out << GEInitWindow;
>>  > #ifdef _WIN32
>>  >         // Let the terminal window know our PID
>>  > -       qt->out << GEPID <<
> quint32(GetCurrentProcessId());
>>  > +       // qt->out << GEPID <<
> quint32(GetCurrentProcessId());
>>  > #endif
>>  >         qt->out << GEActivate;
>>  >         qt->out << GETitle << qt_option->Title;
>>
>>
>>
>>  Yes!
>>
>>  > +       // qt->out << GEPID <<
> quint32(GetCurrentProcessId());
>>
>>  The comment out the above makes gnuplot_qt work.
>>
>>  Tatsuro
>
> That demonstrates the problem is not due to changing the order of
> symbols in enum QtGnuplotEventType.
>
> There may be something wrong in the communication of pid information
> between processes or possibly an error from the call to
> AllowSetForegroundWindow(m_pid).  Maybe it needs error-checking?
> Or sanity checking of the m_pid value?
> Anyhow it seems from the symptoms you report that the error comes
> from the code added to allow '--enable-raise-console'.  So I expect
> that the cleanest option for building from unmodified source is to
> configure with
>
>    --disable-raise-console
>
> or (same thing) add a line to config.h
>
>     #define DISABLE_SPACE_RAISES_CONSOLE
>
>
>         Ethan

Windows build does not use configure but use the special makefile.
I add -DDISABLE_SPACE_RAISES_CONSOLE to CFLAGS and build 5.0.6 unmodified source.
However, the qt does not work even if this option is added.

As I showed gdb trace previously
http://gnuplot.10905.n7.nabble.com/Release-5-0-6-td20570.html#a20573
gnuplot_qt seems to close at the point before DISABLE_SPACE_RAISES_CONSOLE check in qt code.
(QtGnuplotWindow.cpp).

Tatsuro


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
gnuplot-beta mailing list
[hidden email]
Membership management via: https://lists.sourceforge.net/lists/listinfo/gnuplot-beta
Reply | Threaded
Open this post in threaded view
|

Re: qt terminal trouble 5.0.6 source on windows build (was Re: Release 5.0.6)

sfeam
On Thursday, 23 March, 2017 08:41:28 Tatsuro MATSUOKA wrote:
 

> >>
> >>  > Does commenting out this one line in qt_term.cpp make it work again?
> >>  >
> >>  > diff -urp gnuplot-5.0.6pre/src/qtterminal/qt_term.cpp
> >>  > gnuplot-5.0.6/src/qtterminal/qt_term.cpp
> >>  > --- gnuplot-5.0.6pre/src/qtterminal/qt_term.cpp 2017-02-25
> > 14:18:30.000000000
> >>  > -0800
> >>  > +++ gnuplot-5.0.6/src/qtterminal/qt_term.cpp    2017-03-21
> > 19:49:24.159719912
> >>  > -0700
> >>  > @@ -537,7 +537,7 @@ void qt_graphics()
> >>  >         qt->out << GEInitWindow;
> >>  > #ifdef _WIN32
> >>  >         // Let the terminal window know our PID
> >>  > -       qt->out << GEPID <<
> > quint32(GetCurrentProcessId());
> >>  > +       // qt->out << GEPID <<
> > quint32(GetCurrentProcessId());
> >>  > #endif
> >>  >         qt->out << GEActivate;
> >>  >         qt->out << GETitle << qt_option->Title;
> >>
> >>
> >>
> >>  Yes!
> >>
> >>  > +       // qt->out << GEPID <<
> > quint32(GetCurrentProcessId());
> >>
> >>  The comment out the above makes gnuplot_qt work.
> >>
> >>  Tatsuro
> >
> > That demonstrates the problem is not due to changing the order of
> > symbols in enum QtGnuplotEventType.
> >
> > There may be something wrong in the communication of pid information
> > between processes or possibly an error from the call to
> > AllowSetForegroundWindow(m_pid).  Maybe it needs error-checking?
> > Or sanity checking of the m_pid value?
> > Anyhow it seems from the symptoms you report that the error comes
> > from the code added to allow '--enable-raise-console'.  So I expect
> > that the cleanest option for building from unmodified source is to
> > configure with
> >
> >    --disable-raise-console
> >
> > or (same thing) add a line to config.h
> >
> >     #define DISABLE_SPACE_RAISES_CONSOLE
> >
> >
> >         Ethan
>
> Windows build does not use configure but use the special makefile.
> I add -DDISABLE_SPACE_RAISES_CONSOLE to CFLAGS and build 5.0.6 unmodified source.
> However, the qt does not work even if this option is added.
>
> As I showed gdb trace previously
> http://gnuplot.10905.n7.nabble.com/Release-5-0-6-td20570.html#a20573
> gnuplot_qt seems to close at the point before DISABLE_SPACE_RAISES_CONSOLE check in qt code.
> (QtGnuplotWindow.cpp).

Perhaps this patch will help.
It adds GEPID to the list of events that should be ignored if they arrive
before gnuplot_qt is ready to handle them.  

--- gnuplot50/src/qtterminal/QtGnuplotEvent.cpp 2015-08-20 10:24:39.000000000 -0700
+++ gnuplot-5.0.6/src/qtterminal/QtGnuplotEvent.cpp 2017-03-22 17:10:13.004011326 -0700
@@ -183,5 +183,6 @@ void QtGnuplotEventReceiver::swallowEven
  else if (type == GERaise)            ;               // 1034
  else if (type == GEDesactivate)      ;               // 1038
  else if (type == GESetPosition)      in >> point;
+ else if (type == GEPID)              in >> i;
  else qDebug() << "Event not swallowed !" << type;
 }

This patch looks correct to me even if it does not fix your problem,
so I will add it to CVS.  But if it does fix your problem you should
add it to 5.0.6 also in order to get a working Windows build.

        Ethan




------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
gnuplot-beta mailing list
[hidden email]
Membership management via: https://lists.sourceforge.net/lists/listinfo/gnuplot-beta
Reply | Threaded
Open this post in threaded view
|

Re: qt terminal trouble 5.0.6 source on windows build (was Re: Release 5.0.6)

sfeam
Aha!

Finally I understand how the position of GEPID in the enum could make a difference.
It is because of these lines here:

QtGnuplotEvent.cpp: 123

             if ((type < 1000) || (type > GEDone))
                        {
                        // FIXME EAM - At this point the program cannot recover and
                        // if we try to continue it will eventually become a zombie.
                        // Better to just exit explicitly right now.
                                qDebug() << "qt_gnuplot exiting on read error";
                                exit(0);
                                // return;
                        }

So it really does treat the event differently if the code comes after GEDone.
Sigh.

OK, please revert my change to place GEPID at the end so that the
Windows executables work properly.  That would break my debugging things
on linux, but the windows code won't be run on linux anyhow.

I will think about how to make this more fool-proof and make sure that it
does not break either linux or Windows in the future.


Maybe it is a bit late to ask, but is the raise-console option really necessary
on Windows?   In truth my preferred option would be to get rid of it, in which
case GEPID is not needed anyhow.

        Ethan

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
gnuplot-beta mailing list
[hidden email]
Membership management via: https://lists.sourceforge.net/lists/listinfo/gnuplot-beta
Reply | Threaded
Open this post in threaded view
|

Re: qt terminal trouble 5.0.6 source on windows build (was Re: Release 5.0.6)

tmacchant
In reply to this post by sfeam
----- Original Message -----

> From: Ethan A Merritt <[hidden email]>
> To: [hidden email]; Tatsuro MATSUOKA <[hidden email]>
> Cc: [hidden email]
> Date: 2017/3/23, Thu 09:18
> Subject: Re: qt terminal trouble 5.0.6 source on windows build (was Re: Release 5.0.6)
>
> On Thursday, 23 March, 2017 08:41:28 Tatsuro MATSUOKA wrote:
>
>>  >>
>>  >>  > Does commenting out this one line in qt_term.cpp make it
> work again?
>>  >>  >
>>  >>  > diff -urp gnuplot-5.0.6pre/src/qtterminal/qt_term.cpp
>>  >>  > gnuplot-5.0.6/src/qtterminal/qt_term.cpp
>>  >>  > --- gnuplot-5.0.6pre/src/qtterminal/qt_term.cpp 2017-02-25
>>  > 14:18:30.000000000
>>  >>  > -0800
>>  >>  > +++ gnuplot-5.0.6/src/qtterminal/qt_term.cpp    2017-03-21
>>  > 19:49:24.159719912
>>  >>  > -0700
>>  >>  > @@ -537,7 +537,7 @@ void qt_graphics()
>>  >>  >         qt->out << GEInitWindow;
>>  >>  > #ifdef _WIN32
>>  >>  >         // Let the terminal window know our PID
>>  >>  > -       qt->out << GEPID <<
>>  > quint32(GetCurrentProcessId());
>>  >>  > +       // qt->out << GEPID <<
>>  > quint32(GetCurrentProcessId());
>>  >>  > #endif
>>  >>  >         qt->out << GEActivate;
>>  >>  >         qt->out << GETitle <<
> qt_option->Title;
>>  >>
>>  >>
>>  >>
>>  >>  Yes!
>>  >>
>>  >>  > +       // qt->out << GEPID <<
>>  > quint32(GetCurrentProcessId());
>>  >>
>>  >>  The comment out the above makes gnuplot_qt work.
>>  >>
>>  >>  Tatsuro
>>  >
>>  > That demonstrates the problem is not due to changing the order of
>>  > symbols in enum QtGnuplotEventType.
>>  >
>>  > There may be something wrong in the communication of pid information
>>  > between processes or possibly an error from the call to
>>  > AllowSetForegroundWindow(m_pid).  Maybe it needs error-checking?
>>  > Or sanity checking of the m_pid value?
>>  > Anyhow it seems from the symptoms you report that the error comes
>>  > from the code added to allow '--enable-raise-console'.  So I
> expect
>>  > that the cleanest option for building from unmodified source is to
>>  > configure with
>>  >
>>  >    --disable-raise-console
>>  >
>>  > or (same thing) add a line to config.h
>>  >
>>  >     #define DISABLE_SPACE_RAISES_CONSOLE
>>  >
>>  >
>>  >         Ethan
>>
>>  Windows build does not use configure but use the special makefile.
>>  I add -DDISABLE_SPACE_RAISES_CONSOLE to CFLAGS and build 5.0.6 unmodified
> source.
>>  However, the qt does not work even if this option is added.
>>
>>  As I showed gdb trace previously
>>  http://gnuplot.10905.n7.nabble.com/Release-5-0-6-td20570.html#a20573
>>  gnuplot_qt seems to close at the point before DISABLE_SPACE_RAISES_CONSOLE
> check in qt code.
>>  (QtGnuplotWindow.cpp).
>
> Perhaps this patch will help.
> It adds GEPID to the list of events that should be ignored if they arrive
> before gnuplot_qt is ready to handle them. 
>
> --- gnuplot50/src/qtterminal/QtGnuplotEvent.cpp    2015-08-20 10:24:39.000000000
> -0700
> +++ gnuplot-5.0.6/src/qtterminal/QtGnuplotEvent.cpp    2017-03-22
> 17:10:13.004011326 -0700
> @@ -183,5 +183,6 @@ void QtGnuplotEventReceiver::swallowEven
>     else if (type == GERaise)            ;               // 1034
>     else if (type == GEDesactivate)      ;               // 1038
>     else if (type == GESetPosition)      in >> point;
> +    else if (type == GEPID)              in >> i;
>     else qDebug() << "Event not swallowed !" << type;
> }
>
> This patch looks correct to me even if it does not fix your problem,
> so I will add it to CVS.  But if it does fix your problem you should
> add it to 5.0.6 also in order to get a working Windows build.
>
>     Ethan

Thank for your kind reply.

Unfortunately the patch above gave the same result.

I traced code with gdb gnuplot_qt terminates at the same line as posted previously in qt_term.cpp

(gdb) n
550             qt_sendFont();
(gdb) n

Here gnuplot_qt terminates again.

I should do child process debug but I do not have enough knowledge to do that
at this moment.

Tatsuro

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
gnuplot-beta mailing list
[hidden email]
Membership management via: https://lists.sourceforge.net/lists/listinfo/gnuplot-beta
Reply | Threaded
Open this post in threaded view
|

Re: qt terminal trouble 5.0.6 source on windows build (was Re: Release 5.0.6)

tmacchant
In reply to this post by sfeam


----- Original Message -----

> From: sfeam
> To: gnuplot-beta
> Cc: Tatsuro MATSUOKA <tmacchant3; bmaerkisch
> Date: 2017/3/23, Thu 10:58
> Subject: Re: qt terminal trouble 5.0.6 source on windows build (was Re: Release 5.0.6)
>
> Aha!
>
> Finally I understand how the position of GEPID in the enum could make a
> difference.
> It is because of these lines here:
>
> QtGnuplotEvent.cpp: 123
>
>              if ((type < 1000) || (type > GEDone))
>                         {
>                         // FIXME EAM - At this point the program cannot recover
> and
>                         // if we try to continue it will eventually become a
> zombie.
>                         // Better to just exit explicitly right now.
>                                 qDebug() << "qt_gnuplot exiting on
> read error";
>                                 exit(0);
>                                 // return;
>                         }
>
> So it really does treat the event differently if the code comes after GEDone.
> Sigh.
>
> OK, please revert my change to place GEPID at the end so that the
> Windows executables work properly.  That would break my debugging things
> on linux, but the windows code won't be run on linux anyhow.
>
> I will think about how to make this more fool-proof and make sure that it
> does not break either linux or Windows in the future.
>
>
> Maybe it is a bit late to ask, but is the raise-console option really necessary
> on Windows?   In truth my preferred option would be to get rid of it, in which
> case GEPID is not needed anyhow.
>
>     Ethan

Excuse me I have posted reply to the previous post before seeing this post.

> Maybe it is a bit late to ask, but is the raise-console option really necessary
> on Windows?   In truth my preferred option would be to get rid of it, in which
> case GEPID is not needed anyhow.

The raise-console option for qt for windows is implemented by Bastain.
Perhaps he will give you reply for this matter.

If I build binary using revert changes for QtGnuplotEvent.h, should I do the following
in Copyright?

 *   1. distribute the corresponding source modifications from the
 *    released version in the form of a patch file along with the binaries,
 *   2. add special version identification to distinguish your version
 *    in addition to the base release version number,
 *   3. provide your name and address as the primary contact for the
 *    support of your modified version, and
 *   4. retain our contact information in regard to use of the base
 *    software.

Tatsuro


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
gnuplot-beta mailing list
[hidden email]
Membership management via: https://lists.sourceforge.net/lists/listinfo/gnuplot-beta
Reply | Threaded
Open this post in threaded view
|

Aw: Re: qt terminal trouble 5.0.6 source on windows build (was Re: Release 5.0.6)

Bastian Märkisch
In reply to this post by sfeam
> Gesendet: Donnerstag, 23. März 2017 um 02:58 Uhr
> Von: sfeam <[hidden email]>
>
> Aha!
>
> Finally I understand how the position of GEPID in the enum could make a difference.
> It is because of these lines here:
>
> QtGnuplotEvent.cpp: 123
>
>              if ((type < 1000) || (type > GEDone))
>                         {
>                         // FIXME EAM - At this point the program cannot recover and
>                         // if we try to continue it will eventually become a zombie.
>                         // Better to just exit explicitly right now.
>                                 qDebug() << "qt_gnuplot exiting on read error";
>                                 exit(0);
>                                 // return;
>                         }
>
> So it really does treat the event differently if the code comes after GEDone.
> Sigh.
>
> OK, please revert my change to place GEPID at the end so that the
> Windows executables work properly.  That would break my debugging things
> on linux, but the windows code won't be run on linux anyhow.
>
> I will think about how to make this more fool-proof and make sure that it
> does not break either linux or Windows in the future.
>
>
> Maybe it is a bit late to ask, but is the raise-console option really necessary
> on Windows?   In truth my preferred option would be to get rid of it, in which
> case GEPID is not needed anyhow.
>
> Ethan
>

Yes. raise-console is a must-have in my opinion. Personally, I use it all the time.
Also it works flawlessly on Windows for wgnuplot and console mode gnuplot in a cmd
shell - at least for windows and wxt terminal, but also for qt on the systems I
tested it. But I am not opposed to allow "space" to be bound via "bind".

As I currently cannot reproduce the problem Tatsuro is seeing, it is a bit
more difficult to debug.  In particular, changing the order of definitions for
QEPID does not change anything here.  Weird.

  Bastian


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
gnuplot-beta mailing list
[hidden email]
Membership management via: https://lists.sourceforge.net/lists/listinfo/gnuplot-beta