cannot compile doc2html.c on current cvs (2016-01-31) on MinGW

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

cannot compile doc2html.c on current cvs (2016-01-31) on MinGW

tmacchant
Hello

I have tried to build the recent cvs tree using  MinGW.

In compiling doc2html.c, I have met a following error.

gcc  <snip>
../../docs/windows/doc2html.c ../../docs/termdoc.c ../../docs/xref.c version.co

../../docs/windows/doc2html.c: In function 'convert':
../../docs/windows/doc2html.c:171:72: error: 'VERSION_MAJOR' undeclared (first use in this function)
     fprintf(b, "<h1 align=\"center\">gnuplot %s patchlevel %s</h1>\n", VERSION_MAJOR, PATCHLEVEL);
                                                                        ^
../../docs/windows/doc2html.c:171:72: note: each undeclared identifier is reported only once for each function it appears in
../../docs/windows/doc2html.c:171:87: error: 'PATCHLEVEL' undeclared (first use in this function)
     fprintf(b, "<h1 align=\"center\">gnuplot %s patchlevel %s</h1>\n", VERSION_MAJOR, PATCHLEVEL);


For gnuplot 5.0.1, the corresponding line was
fprintf(b, "<h1 align=\"center\">gnuplot %s patchlevel %s</h1>\n",  gnuplot_version, gnuplot_patchlevel);


Perhaps config.mgw should be modified to define VERSION_MAJOR and  PATCHLEVEL values.
Am I right?

Tatsuro

------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
gnuplot-beta mailing list
[hidden email]
Membership management via: https://lists.sourceforge.net/lists/listinfo/gnuplot-beta
Reply | Threaded
Open this post in threaded view
|

Re: cannot compile doc2html.c on current cvs (2016-01-31) on MinGW

tmacchant
----- Original Message -----

> From: Tatsuro MATSUOKA 
> To: gnuplot-beta
> Cc:
> Date: 2016/2/3, Wed 13:24
> Subject: cannot compile doc2html.c on current cvs (2016-01-31) on MinGW
>
> Hello
>
> I have tried to build the recent cvs tree using  MinGW.
>
> In compiling doc2html.c, I have met a following error.
>
> gcc  <snip>
> ../../docs/windows/doc2html.c ../../docs/termdoc.c ../../docs/xref.c version.co
>
> ../../docs/windows/doc2html.c: In function 'convert':
> ../../docs/windows/doc2html.c:171:72: error: 'VERSION_MAJOR' undeclared
> (first use in this function)
>      fprintf(b, "<h1 align=\"center\">gnuplot %s
> patchlevel %s</h1>\n", VERSION_MAJOR, PATCHLEVEL);
>                                                                         ^
> ../../docs/windows/doc2html.c:171:72: note: each undeclared identifier is
> reported only once for each function it appears in
> ../../docs/windows/doc2html.c:171:87: error: 'PATCHLEVEL' undeclared
> (first use in this function)
>      fprintf(b, "<h1 align=\"center\">gnuplot %s
> patchlevel %s</h1>\n", VERSION_MAJOR, PATCHLEVEL);
>
>
> For gnuplot 5.0.1, the corresponding line was
> fprintf(b, "<h1 align=\"center\">gnuplot %s
> patchlevel %s</h1>\n",  gnuplot_version, gnuplot_patchlevel);
>
>
> Perhaps config.mgw should be modified to define VERSION_MAJOR and  PATCHLEVEL
> values.
> Am I right?
>
> Tatsuro

I have made a patch to config/config.mgw.

A patch file is attached.

Tatsuro
------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
gnuplot-beta mailing list
[hidden email]
Membership management via: https://lists.sourceforge.net/lists/listinfo/gnuplot-beta

VersionMinGW.patch (922 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: cannot compile doc2html.c on current cvs (2016-01-31) on MinGW

Jun T.
In reply to this post by tmacchant

On 2016/02/03, at 13:24, Tatsuro MATSUOKA <[hidden email]> wrote:
> I have tried to build the recent cvs tree using  MinGW.
> (snip)
> ../../docs/windows/doc2html.c:171:72: error: 'VERSION_MAJOR' undeclared (first use in this function)

Sorry, I haven't realized that there are systems on which configure
is not used for generating config.h (and Makefiles).

> I have made a patch to config/config.mgw.

Yes, it should work, but you need to update config.mgw every time
the PATCHLEVEL (or VERSION) changes.

I can't test on MinGW now, but if the patch attached below works then
it would be somewhat better.

I guess config/msvc/Makefile needs similar change.


------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
gnuplot-beta mailing list
[hidden email]
Membership management via: https://lists.sourceforge.net/lists/listinfo/gnuplot-beta

mingw-makefile.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: cannot compile doc2html.c on current cvs (2016-01-31) on MinGW

tmacchant
----- Original Message -----

> From: Jun T.
> To: "[hidden email]
> Cc: Tatsuro MATSUOKA
> Date: 2016/2/3, Wed 16:08
> Subject: Re: cannot compile doc2html.c on current cvs (2016-01-31) on MinGW
>
>
> On 2016/02/03, at 13:24, Tatsuro MATSUOKA <[hidden email]> wrote:
>>  I have tried to build the recent cvs tree using  MinGW.
>>  (snip)
>>  ../../docs/windows/doc2html.c:171:72: error: 'VERSION_MAJOR'
> undeclared (first use in this function)
>
> Sorry, I haven't realized that there are systems on which configure
> is not used for generating config.h (and Makefiles).
>
>>  I have made a patch to config/config.mgw.
>
> Yes, it should work, but you need to update config.mgw every time
> the PATCHLEVEL (or VERSION) changes.
>
> I can't test on MinGW now, but if the patch attached below works then
> it would be somewhat better.


It works perfectly! 
Thanks for your excellent solution.

I hope that this patch will be applied in the cvs source. 


> I guess config/msvc/Makefile needs similar change.
Unfortunately I do not have build environment and knowledge of msvc. 

Tatsuro

------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
gnuplot-beta mailing list
[hidden email]
Membership management via: https://lists.sourceforge.net/lists/listinfo/gnuplot-beta
Reply | Threaded
Open this post in threaded view
|

Re: cannot compile doc2html.c on current cvs (2016-01-31) on MinGW

tmacchant
----- Original Message -----

> From: Tatsuro MATSUOKA 
> To: Jun T. ; gnuplot-beta
> Cc:
> Date: 2016/2/3, Wed 16:46
> Subject: Re: cannot compile doc2html.c on current cvs (2016-01-31) on MinGW
>
> ----- Original Message -----
>
>>  From: Jun T.
>>  To: "[hidden email]
>>  Cc: Tatsuro MATSUOKA
>>  Date: 2016/2/3, Wed 16:08
>>  Subject: Re: cannot compile doc2html.c on current cvs (2016-01-31) on MinGW
>>
>>
>>  On 2016/02/03, at 13:24, Tatsuro MATSUOKA <[hidden email]>
> wrote:
>>>   I have tried to build the recent cvs tree using  MinGW.
>>>   (snip)
>>>   ../../docs/windows/doc2html.c:171:72: error: 'VERSION_MAJOR'
>>  undeclared (first use in this function)
>>
>>  Sorry, I haven't realized that there are systems on which configure
>>  is not used for generating config.h (and Makefiles).
>>
>>>   I have made a patch to config/config.mgw.
>>
>>  Yes, it should work, but you need to update config.mgw every time
>>  the PATCHLEVEL (or VERSION) changes.
>>
>>  I can't test on MinGW now, but if the patch attached below works then
>>  it would be somewhat better.
>
>
> It works perfectly! 
> Thanks for your excellent solution.
>
> I hope that this patch will be applied in the cvs source. 
>


I confirmed the patch was applied to cvs tree and the corrected makefile worked.

Thanks!

Tatsuro

------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140
_______________________________________________
gnuplot-beta mailing list
[hidden email]
Membership management via: https://lists.sourceforge.net/lists/listinfo/gnuplot-beta