right-click doing line toggle on QT

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

right-click doing line toggle on QT

Plotter-2
Hi,

a minor but persistently annoying bug on gnuplot-qt ( as provided by
Fedora 23 ) :

Fedora provide separate builds for gnuplot  ( aka gnuplot-qt ) and
gnuplot-wx


        G N U P L O T
        Version 5.0 patchlevel 1    last modified 2015-06-07


On the qt build a right mouse click in the plot area to select a zoom
area is also triggering the line visibility toggle if it happens on the
legend part of the graph. This is very annoying since it hides the line
you may be trying to zoom on making it impossible to accurately choose
the zoom area.

Clearly this feature should be restricted to left-mouse clicks. This is
the case in wxt , so I presume that it's an error.




In passing I also report that when qt terminal toggles a line the legend
gets a mid-grey background colour that is very ugly.  Presumably someone
thought it could indicated a non-visible line.

I would submit that it just makes a visual mess of the graph and is not
even helpful since it renders the legend pretty much visible anyway.

Same on wxt but legible.. Probably grey too dark on qt.

I seem to recall that it was the line sample in the legend that got
turned off along with the line. This communicates the same information
in an aesthetically more acceptable manner, IMO.


Best regards, Peter.


------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
gnuplot-beta mailing list
[hidden email]
Membership management via: https://lists.sourceforge.net/lists/listinfo/gnuplot-beta
Reply | Threaded
Open this post in threaded view
|

Re: right-click doing line toggle on QT

sfeam

On Monday, 25 January, 2016 13:21:55 [hidden email] wrote:

> Hi,

>

> a minor but persistently annoying bug on gnuplot-qt ( as provided by

> Fedora 23 ) :

 

> On the qt build a right mouse click in the plot area to select a zoom

> area is also triggering the line visibility toggle if it happens on the

> legend part of the graph. This is very annoying since it hides the line

> you may be trying to zoom on making it impossible to accurately choose

> the zoom area.

>

> Clearly this feature should be restricted to left-mouse clicks. This is

> the case in wxt , so I presume that it's an error.

 

Good point. (Easy to fix, too :-)

 

> In passing I also report that when qt terminal toggles a line the legend

> gets a mid-grey background colour that is very ugly. Presumably someone

> thought it could indicated a non-visible line.

>

> I would submit that it just makes a visual mess of the graph and is not

> even helpful since it renders the legend pretty much visible anyway.

 

Did you mean to say "invisible"?

It looks OK to me, but I suppose tastes and computer displays vary.

 

> Same on wxt but legible.. Probably grey too dark on qt.

>

> I seem to recall that it was the line sample in the legend that got

> turned off along with the line. This communicates the same information

> in an aesthetically more acceptable manner, IMO.

 

Yeah, but if you toggle off the line sample there is nothing to

click on any more. How would you toggle it back on again?

There would have to be some other clickable placeholder.

 

Ethan

 


------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
gnuplot-beta mailing list
[hidden email]
Membership management via: https://lists.sourceforge.net/lists/listinfo/gnuplot-beta
Reply | Threaded
Open this post in threaded view
|

Re: right-click doing line toggle on QT

Plotter-2
On 25/01/16 19:07, Ethan A Merritt wrote:

> On Monday, 25 January, 2016 13:21:55 [hidden email] wrote:
>
>  > Hi,
>
>  >
>
>  > a minor but persistently annoying bug on gnuplot-qt ( as provided by
>
>  > Fedora 23 ) :
>
>  > On the qt build a right mouse click in the plot area to select a zoom
>
>  > area is also triggering the line visibility toggle if it happens on the
>
>  > legend part of the graph. This is very annoying since it hides the line
>
>  > you may be trying to zoom on making it impossible to accurately choose
>
>  > the zoom area.
>
>  >
>
>  > Clearly this feature should be restricted to left-mouse clicks. This is
>
>  > the case in wxt , so I presume that it's an error.
>
> Good point. (Easy to fix, too :-)
>
>  > In passing I also report that when qt terminal toggles a line the legend
>
>  > gets a mid-grey background colour that is very ugly. Presumably someone
>
>  > thought it could indicated a non-visible line.
>
>  >
>
>  > I would submit that it just makes a visual mess of the graph and is not
>
>  > even helpful since it renders the legend pretty much visible anyway.
>
> Did you mean to say "invisible"?
>
> It looks OK to me, but I suppose tastes and computer displays vary.

Yes: invisible, sorry.

As I said it looks more reasonable in wxt.  QT is way too dark and makes
it illegible ( on my monitor ) and an ugly dark block.    Colour
inconsistencies between terminals is already a bit of a problem.

>
>  > Same on wxt but legible.. Probably grey too dark on qt.
>
>  >
>
>  > I seem to recall that it was the line sample in the legend that got
>
>  > turned off along with the line. This communicates the same information
>
>  > in an aesthetically more acceptable manner, IMO.
>
> Yeah, but if you toggle off the line sample there is nothing to
>
> click on any more. How would you toggle it back on again?
>
> There would have to be some other clickable placeholder.


No, the legend text itself is also clickable. It may make more sense if
the line in the legend went 'hidden' as well ;)   IIRC that's what the
SVG terminal mouse action  does.

Peter

>
> Ethan
>


------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
gnuplot-beta mailing list
[hidden email]
Membership management via: https://lists.sourceforge.net/lists/listinfo/gnuplot-beta
Reply | Threaded
Open this post in threaded view
|

Re: right-click doing line toggle on QT

sfeam

On Tuesday, 26 January, 2016 12:51:07 [hidden email] wrote:

> On 25/01/16 19:07, Ethan A Merritt wrote:

> > On Monday, 25 January, 2016 13:21:55 [hidden email] wrote:

> >

 

> > > In passing I also report that when qt terminal toggles a line the legend

> > > gets a mid-grey background colour that is very ugly. Presumably someone

> > > thought it could indicated a non-visible line.

> >

> > > I would submit that it just makes a visual mess of the graph and is not

> > > even helpful since it renders the legend pretty much visible anyway.

> >

> > Did you mean to say "invisible"?

> > It looks OK to me, but I suppose tastes and computer displays vary.

>

> Yes: invisible, sorry.

>

> As I said it looks more reasonable in wxt. QT is way too dark and makes

> it illegible ( on my monitor ) and an ugly dark block. Colour

> inconsistencies between terminals is already a bit of a problem.

> >

> > > Same on wxt but legible.. Probably grey too dark on qt.

 

FWIW there is no explicit color involved.

What you see is a bitmask Qt::Dense4Pattern.

I wonder if the implementation of that mask varies by platform or by

Qt version? Or perhaps there is a default color associated with the

bitmask that is different on our two machines?

 

Here is a patch that makes the color explicit rather than whatever

it defaults to. Does it help?

 

-- gnuplot/src/qtterminal/QtGnuplotScene.cpp 2016-01-25 11:23:41.000000000 -0800

+++ gnuplot-cvs/src/qtterminal/QtGnuplotScene.cpp 2016-01-26 10:44:23.000000000 -0800

@@ -554,7 +554,9 @@ void QtGnuplotScene::processEvent(QtGnup

// Draw an invisible grey rectangle in the key box.

// It will be set to visible if the plot is toggled off.

QtGnuplotKeybox *keybox = &m_key_boxes[m_currentPlotNumber-1];

- QGraphicsRectItem *statusBox = addRect(*keybox, Qt::NoPen, Qt::Dense4Pattern);

+ m_currentBrush.setColor(Qt::gray);

+ m_currentBrush.setStyle(Qt::Dense4Pattern);

+ QGraphicsRectItem *statusBox = addRect(*keybox, Qt::NoPen, m_currentBrush);

statusBox->setZValue(m_currentZ-1);

keybox->showStatus(statusBox);

 

 

Ethan


------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
gnuplot-beta mailing list
[hidden email]
Membership management via: https://lists.sourceforge.net/lists/listinfo/gnuplot-beta
Reply | Threaded
Open this post in threaded view
|

Re: right-click doing line toggle on QT

Plotter-2
On 26/01/16 19:02, Ethan A Merritt wrote:

> On Tuesday, 26 January, 2016 12:51:07 [hidden email] wrote:
>
>  > On 25/01/16 19:07, Ethan A Merritt wrote:
>
>  > > On Monday, 25 January, 2016 13:21:55 [hidden email] wrote:
>
>  > >
>
>  > > > In passing I also report that when qt terminal toggles a line the
> legend
>
>  > > > gets a mid-grey background colour that is very ugly. Presumably
> someone
>
>  > > > thought it could indicated a non-visible line.
>
>  > >
>
>  > > > I would submit that it just makes a visual mess of the graph and
> is not
>
>  > > > even helpful since it renders the legend pretty much visible anyway.
>
>  > >
>
>  > > Did you mean to say "invisible"?
>
>  > > It looks OK to me, but I suppose tastes and computer displays vary.
>
>  >
>
>  > Yes: invisible, sorry.
>
>  >
>
>  > As I said it looks more reasonable in wxt. QT is way too dark and makes
>
>  > it illegible ( on my monitor ) and an ugly dark block. Colour
>
>  > inconsistencies between terminals is already a bit of a problem.
>
>  > >
>
>  > > > Same on wxt but legible.. Probably grey too dark on qt.
>
> FWIW there is no explicit color involved.
>
> What you see is a bitmask Qt::Dense4Pattern.
>
> I wonder if the implementation of that mask varies by platform or by
>
> Qt version? Or perhaps there is a default color associated with the
>
> bitmask that is different on our two machines?
>
> Here is a patch that makes the color explicit rather than whatever
>
> it defaults to. Does it help?
>
> -- gnuplot/src/qtterminal/QtGnuplotScene.cpp 2016-01-25
> 11:23:41.000000000 -0800
>
> +++ gnuplot-cvs/src/qtterminal/QtGnuplotScene.cpp 2016-01-26
> 10:44:23.000000000 -0800
>
> @@ -554,7 +554,9 @@ void QtGnuplotScene::processEvent(QtGnup
>
> // Draw an invisible grey rectangle in the key box.
>
> // It will be set to visible if the plot is toggled off.
>
> QtGnuplotKeybox *keybox = &m_key_boxes[m_currentPlotNumber-1];
>
> - QGraphicsRectItem *statusBox = addRect(*keybox, Qt::NoPen,
> Qt::Dense4Pattern);
>
> + m_currentBrush.setColor(Qt::gray);
>
> + m_currentBrush.setStyle(Qt::Dense4Pattern);
>
> + QGraphicsRectItem *statusBox = addRect(*keybox, Qt::NoPen,
> m_currentBrush);
>
> statusBox->setZValue(m_currentZ-1);
>
> keybox->showStatus(statusBox);
>
> Ethan
>

Thanks for the patch but I'm not running CVS any more on this system. I
had wasted too much time just trying to get it to compile.

I ended up going with the distro packages.

I may have another go later , when I get some time.

Peter.


------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
gnuplot-beta mailing list
[hidden email]
Membership management via: https://lists.sourceforge.net/lists/listinfo/gnuplot-beta